Uh oh!
There was an error while loading. Please reload this page.
Making release() and time() async - #170
Merged
lovelydinosaur merged 3 commits intoAug 26, 2020
Merged
Conversation
Merged
lovelydinosaur
approved these changes
Aug 25, 2020
Contributor
There was a problem hiding this comment.
Yup, I think this'll be fairly uncontroversial.
Wouldn't mind a second review over it, but otherwise I'm good with this.
Note to all: We need this because curio has different expectations (for perfectly decent reasons) about which methods should/shouldn't expose an async interface. Given that this async interface can still call into a sync implementation for trio and asyncio, but that the converse would not be true, we're not really losing anything by adopting curio's constraints in our own internal backend API here.
florimondmanca
approved these changes
Aug 25, 2020
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #169 and #168 you can find pretty the same changes:
AsyncBackend::time,AsyncSemaphore::releaseandAsyncLock::releasehave been made async.I extracted these changes into the separated PR to make the changeset be discussed here.