Skip to content

Add local_address support for curio - #176

Merged
florimondmanca merged 1 commit into
masterfrom
fm/curio-local-address
Sep 14, 2020
Merged

Add local_address support for curio#176
florimondmanca merged 1 commit into
masterfrom
fm/curio-local-address

Conversation

@florimondmanca

@florimondmancaflorimondmanca commented Sep 5, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Realized that #175 did not make use of the local_address parameter (refs #134).

Relevant part of the curio docs is here: https://curio.readthedocs.io/en/latest/reference.html#open_connection

source_addr specifies the source address to use on the socket.

@florimondmanca
florimondmanca requested a review from a teamSeptember 5, 2020 09:24
florimondmanca
florimondmanca commented Sep 5, 2020
View reviewed changes
Comment threadtests/sync_tests/test_interfaces.py
@florimondmanca

florimondmanca commented Sep 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Dropped the dependency of this PR on #177, since we can add the test assertion separately. This PR should be reviewable and mergeable now!

@florimondmanca
florimondmanca merged commit b3d8ec3 into masterSep 14, 2020
@florimondmanca
florimondmanca deleted the fm/curio-local-address branch September 14, 2020 08:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@cdelercdelercdeler approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florimondmanca@cdeler