Uh oh!
There was an error while loading. Please reload this page.
Add support for backend="anyio" - #180
Conversation
lovelydinosaur
commented
Sep 9, 2020
Also, I think this change bumps up our minimum required (I happened to be running locally with trio 0.14.0, which passed our existing test suite, but failed with |
agronholm
commented
Sep 10, 2020
This won't test the explicit backends used by the "auto" backend though, does it? |
lovelydinosaur
commented
Sep 10, 2020
At this point in time, yup. It's only testing asyncdeftest_http_request() ->None:
asyncwithhttpcore.AsyncConnectionPool(backend="anyio") ashttp: # Explicitly testing against anyio only.method=b"GET"url= (b"http", b"example.org", 80, b"/")
headers= [(b"host", b"example.org")]The last step here would be to parameterise it so that both |
florimondmanca
commented
Sep 13, 2020
Closing tentatively since it looks like the suggestions from this PR were integrated into #169. :-) |
Builds on #169, with a minimal as possible change footprint.
Last hurdle to clear would be switching out the cases where I've used
backend="anyio"to be parameterized to use bothbackend="auto"|"anyio". Theunasync.pyscript will need to strip out that parameterisation for the sync case, which needs to just always usebackend="sync".I'm really keen on us also using anyio to slim down any gnarly in the test suite that it can help us address, but we should treat that as an entirely isolated issue. (Using
anyioto run our tests is an independent concern to what backend implementation we want to use.)