You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
See discussion in encode/httpx#1283.
Completely ignoring a lint should be done with careful thought and agreement. I for one would rather ignore it where it's necessary, rather than across the entire project, but others in @encode/maintainers need to chime in as well.
The reason will be displayed to describe this comment to others. Learn more.
I'm merging this to unblock other PRs, we can reassess later whether we're okay keeping inline # noqa, or if we'd like to just ignore this error in setup.cfg, or just pin to the previous version. 👍
Just to mention that I really do think it's worth ignoring this in setup.cfg. I wouldn't have an issue with this if it only failed linting on except BaseException, but except Exception is a perfectly normal sensible thing to do, and shouldn't need per-line linter exclusions. 😃
We could also review all our except Exception cases in tandem with that change, in order to assess if any of them could be more tightly defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.