Uh oh!
There was an error while loading. Please reload this page.
Pin dependencies in requirements.txt and add Dependabot - #184
Conversation
e078622 to
9ac5e76CompareUh oh!
There was an error while loading. Please reload this page.
lovelydinosaur
commented
Sep 14, 2020
Right, that's interesting. It's not actually as strictly frozen as #162 - we could still get bitten by a transitive dependancy updating, but practically it's probably actually enough for us almost always, and it's nice and simple this ways. 🤷♂️ |
florimondmanca
commented
Sep 14, 2020
@tomchristie Which do you consider simpler? In my mind this PR is a simpler approach at first - at least were explicitly pinning what were using. Even if transitive deps might shift, all "sudden CI breaking" issues I've personally had in the past were due to top level dependencies shifting with breaking changes, not transitive dependencies. |
lovelydinosaur
commented
Sep 14, 2020
Indeed yup. Let's roll with this, lovely and simple. We could always reassess another day if we needed. |
Alternative to #162
This PR pins all entries in our current
requirements.txt.Does not include a freeze process, so that we don't have to deal with transitive dependencies cross-platform (see #162 (comment)).
This way this would work is:
requirements.txt. Top-level dependencies are pinned, underlying dependencies may change. We assume the pip 2020 resolver will always be able to find transitive dependencies that work. Should work on Linux, macOS, Windows, and any supported Python version.