Uh oh!
There was an error while loading. Please reload this page.
Abstract away example.org in interface tests - #204
Merged
Conversation
lovelydinosaur
approved these changes
Oct 2, 2020
lovelydinosaur
left a comment
Contributor
There was a problem hiding this comment.
Great approach, yup! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at reducing the scope of #194: as a first step, make our tests agnostic to which "live" endpoint we're hitting, by adding a small
Serverclass and using it intest_interfaces.py(i.e. where we're actually hittingexample.org).Next step would be to add Hypercorn, switch
Server's properties so that it points tolocalhost:<port>, instead ofexample.org, and use that updated version in fixtures.Diff size is still not negligible, but hopefully this is a non-controversial and easily reviewable change.