Uh oh!
There was an error while loading. Please reload this page.
Drop pyproject.toml - #281
Merged
Merged
Conversation
lovelydinosaur
commented
Mar 12, 2021
ContributorAuthor
I don't understand black's behaviour here. Eg... + venv/bin/black --force-exclude 'httpcore/_sync/.*' --force-exclude 'tests/sync_tests/.*' --check --diff --target-version=py36 httpcore tests
would reformat httpcore/_sync/http11.pyBut, I just asked you not to include that file? |
lovelydinosaur
commented
Mar 12, 2021
ContributorAuthor
Okay got it, |
lovelydinosaur
commented
Mar 12, 2021
ContributorAuthor
Okay, so presumably the SSL errors are something to do with the very latest python releases having some newer SSL config. |
florimondmanca
commented
Mar 12, 2021
Contributor
Yup, tracked this under #276 — we've got a test that needs updating to unblock CI. |
florimondmanca
commented
Mar 12, 2021
Contributor
florimondmanca
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Personally I'm not keen on us having a
pyproject.tomlexclusively for some bits of black configuration. We don't have this on our other projects, and I don't particularly appreciate IDE design choices forcing us into particular tooling conventions.I'm okay with us having a conversation around this, but also am very strongly in favour of us being able to stick with similar conventions on our projects across
encode, and striving towards low-config, low-tooling approaches wherever possible. To me this also include narrowing down the number of magical configuration files we have at the top-level.Also, I needed a PR excuse to have a look at the latest build failure nonsense.