Skip to content

Raise H11 version support for v.0.13 - #503

Closed
fsecada01 wants to merge 5 commits into
encode:masterfrom
fsecada01:patch-1
Closed

Raise H11 version support for v.0.13#503
fsecada01 wants to merge 5 commits into
encode:masterfrom
fsecada01:patch-1

Conversation

@fsecada01

@fsecada01fsecada01 commented Feb 2, 2022

Copy link
Copy Markdown
Contributor
  • Allows for concurrent installation with the latest Uvicorn version
  • Drop support for Python v.3.6

@fsecada01
Update setup.py
1713825
Allow for h11 V. 013. Facilitates installation alongside latest version of Uvicorn.
@fsecada01
Update setup.py
5473307
lovelydinosaur
lovelydinosaur reviewed Feb 3, 2022
View reviewed changes
Comment threadsetup.py Outdated
@lovelydinosaur

lovelydinosaur commented Feb 3, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Alrighty - h11 0.13 adds type annotations, which as it happens causes our CI to fail.
The code is correct, but it fails mypy.

Not a big deal but needs a bit of tweaking so that we're still passing mypy's type checking.

@zaniebzanieb mentioned this pull request Feb 18, 2022
Closed
mgorny
mgorny reviewed Feb 27, 2022
View reviewed changes
Comment threadsetup.py
zip_safe=False,
install_requires=[
"h11>=0.11,<0.13",
"h11>=0.11,<=0.13",

@mgornymgornyFeb 27, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"h11>=0.11,<=0.13",
"h11>=0.11,<0.14",

It's rather unlikely that e.g. 0.13.1 will break anything.

@bdracobdraco mentioned this pull request Mar 1, 2022
Merged
22 tasks
@zaniebzanieb mentioned this pull request Mar 25, 2022
Closed
@stale

staleBot commented Mar 31, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestaleBot added the wontfix This will not be worked on label Mar 31, 2022
@stalestaleBot closed this Apr 9, 2022
@GalaxySnail

GalaxySnail commented Apr 9, 2022

Copy link
Copy Markdown

I think it may not be a good idea to pin h11 under 0.14, it can cause unnecessary conflicts. See: https://hynek.me/articles/semver-will-not-save-you/

@zaniebzanieb mentioned this pull request Sep 25, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaurlovelydinosaurlovelydinosaur left review comments
+1 more reviewer
@mgornymgornymgorny left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

wontfixThis will not be worked on

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fsecada01@lovelydinosaur@GalaxySnail@mgorny