Uh oh!
There was an error while loading. Please reload this page.
Script cleanups - #67
Closed
lovelydinosaur wants to merge 2 commits into
Closed
Conversation
yeraydiazdiaz
suggested changes
Apr 30, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Merged
florimondmanca
approved these changes
May 21, 2020
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a question on keeping autoflake8 in 👍
| ${PREFIX}autoflake --in-place --recursive $SOURCE_FILES | ||
| ${PREFIX}isort --project=httpcore --recursive --apply $SOURCE_FILES | ||
| ${PREFIX}black --exclude 'httpcore/_sync/.*' --exclude 'tests/sync_tests/.*' --target-version=py36 $SOURCE_FILES | ||
| ${PREFIX}black --exclude '(httpcore/_sync|tests/sync_tests)/.*' --target-version=py37 ${PACKAGE} tests |
Contributor
There was a problem hiding this comment.
Thoughts on keeping autoflake? If we're adding flake8 to check it's definitely nice to have a quick way to fix things when they're broken.
yeraydiazdiaz
commented
May 21, 2020
Contributor
@euri10 wrong button? |
euri10
commented
May 21, 2020
Phone in my pocket 🙄 sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHONPATH, since we've got a-e .in the requirements.txt anyway.blackandflake8to the checks.PREFIXstyle everywhere.setup.cfgin favour of arguments in the scripts.