Skip to content

Change type of Extensions - #762

Merged
karpetrosyan merged 2 commits into
encode:masterfrom
karpetrosyan:change-extension-type
Jul 28, 2023
Merged

Change type of Extensions#762
karpetrosyan merged 2 commits into
encode:masterfrom
karpetrosyan:change-extension-type

Conversation

@karpetrosyan

@karpetrosyankarpetrosyan commented Jul 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#761

Checklist

  • Change type of the extensions.
  • Update changelog

@karpetrosyan
karpetrosyan requested a review from a teamJuly 28, 2023 11:41
Kludex
Kludex suggested changes Jul 28, 2023
View reviewed changes
Comment threadCHANGELOG.md Outdated
@karpetrosyan@Kludex
Add pr number
c87a628
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@karpetrosyan

karpetrosyan commented Jul 28, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you @Kludex !

@karpetrosyan
karpetrosyan merged commit c86d507 into encode:masterJul 28, 2023
This was referenced Aug 1, 2023
Merged
Merged
@lovelydinosaur

lovelydinosaur commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

Just coming back to this ...and... any reason for use to not use Dict[...] here instead?
Would that be preferable?

@karpetrosyan

karpetrosyan commented Aug 1, 2023

Copy link
Copy Markdown
ContributorAuthor

It makes no difference for httpx; for httpcore, it's just a bit of reusability.

Other libraries built on top of httpcore can use more than just a dictionary.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@PlinerPlinerPliner approved these changes
@KludexKludexKludex approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change the type of extension from Mapping to MutableMapping.

4 participants

@karpetrosyan@lovelydinosaur@Pliner@Kludex