Skip to content

Support sni_hostname extension with SOCKS proxy - #773

Closed
Allgot wants to merge 7 commits into
encode:masterfrom
Allgot:support-sni-hostname-with-socks
Closed

Support sni_hostname extension with SOCKS proxy#773
Allgot wants to merge 7 commits into
encode:masterfrom
Allgot:support-sni-hostname-with-socks

Conversation

@Allgot

Copy link
Copy Markdown
Contributor

Co-authored-by: Tom Christie tom@tomchristie.com

Summary

A new extension, sni_hostname has enalbed users to specify the hostname which would be used during TLS handshake. However, the update was inconsistent, resulting in the incomplete extension. Currently, the sni_hostname extension are not handled if SOCKS proxy is in use. This PR would bridge this gap.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Allgot

Copy link
Copy Markdown
ContributorAuthor

Sorry for the confusing PR. I created a new branch from the HEAD by mistake.

I would close this PR right now, then create new one properly. Sorry.

@AllgotAllgot closed this Aug 8, 2023
@Allgot
Allgot deleted the support-sni-hostname-with-socks branch August 8, 2023 17:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Allgot@Pliner