Uh oh!
There was an error while loading. Please reload this page.
Version 1.0 - #809
Conversation
karpetrosyan
commented
Sep 19, 2023
Do we want #800 after this release? |
Have followed up against that discussion. |
… could change across package versions.
karpetrosyan
left a comment
There was a problem hiding this comment.
We can change the error message in https://github.com/encode/httpcore/pull/809/files#diff-5bb436aadeb1bfe2f41078fe8d1a4db589eb3405df644e07ce5e26c7749da824R40 to something like Running under trio requires the 'httpcore' to be installed with the 'trio' extra. because when the user has trio installed, the current message doesn't make any sense.
zanieb
commented
Sep 26, 2023
Why would that error be displayed when trio is installed? |
karpetrosyan
commented
Sep 27, 2023
When the trio is installed but the sniffio isn't |
lovelydinosaur
commented
Sep 27, 2023
Resolved |
Uh oh!
There was an error while loading. Please reload this page.
lovelydinosaur
commented
Oct 5, 2023
I think we're good to go here... I'll plan on releasing this tomorrow. |
karpetrosyan
commented
Oct 5, 2023
Do we want to include #799 to 1.0.0? |
lovelydinosaur
commented
Oct 5, 2023
Ok. |
karpetrosyan
commented
Oct 6, 2023
Release date 🥶 |
lovelydinosaur
commented
Oct 6, 2023
Oops. (thanks) |
agronholm
commented
Oct 6, 2023
On that note, how are you creating your GitHub releases? I don't see any automation. |
lovelydinosaur
commented
Oct 6, 2023
Copy the release notes. Yup some buttons do get pressed through the GitHub UI. |
agronholm
commented
Oct 6, 2023
In case you're interested, here's how I handle things: https://github.com/agronholm/anyio/blob/master/.github/workflows/publish.yml |
Proposal for
httpcoreversion 1.0.Our API is already stable, and I don't think we've any blockers that ought to prevent us issuing a 1.0 release.
The one change that I am suggesting in this pull request is that we switch to a more minimal set of default dependancies, by making the async case fully optional. We've already done the work on making these packages not strictly required. This proposal builds on that work by no longer installing
anyio/sniffio/trioby default.TODO:
See also https://github.com/encode/httpx/issues/947.