Uh oh!
There was an error while loading. Please reload this page.
Add benchmarking script - #923
Conversation
1bbc3ce to
e4d3bd9CompareUh oh!
There was an error while loading. Please reload this page.
lovelydinosaur
commented
Jun 11, 2024
Great thanks. Is there any sense in us also having the same benchmark for the threaded case? |
MarkusSintonen
commented
Jun 11, 2024
It might make sense for checking the pool optimization with the sync case |
d2d45c8 to
2954aebCompare@tomchristie I added now here the sync benchmark using |
karpetrosyan
commented
Jun 11, 2024
I think the most important part of performance improvement is writing effective benchmarks. So, I have two questions here:
|
2463317 to
1302d5aCompare1302d5a to
86606a3CompareMarkusSintonen
commented
Jun 12, 2024
It doesnt actually work very well when running in a single process as then the benchmark also includes the server side. The sync benchmark especially breaks as the async server wont be able to process the requests as the sync IO is blocking everything. So it would need also to use some threaded sync server which starts to get complex to my taste just for the benchmarking.
Good point, I think it makes sense to use |
lovelydinosaur
commented
Jun 13, 2024
Okay, yes. |
Summary
Adds benchmarking script comparing
httpcoreagainst another popular http libraryaiohttp. Related to performance issueshttpcorehas https://github.com/encode/httpx/issues/3215.This runs 500 requests with 20 requests concurrently. The test is repeated 10 times. Test server has simulated latency of 10ms with 2KB response. Simulating a good network connection (eg in data center conditions).
Checklist