Skip to content

Replace remaining occurrences of dispatch with transport - #1010

Merged
florimondmanca merged 3 commits into
encode:masterfrom
jcugat:dispatch_to_transport
May 30, 2020
Merged

Replace remaining occurrences of dispatch with transport#1010
florimondmanca merged 3 commits into
encode:masterfrom
jcugat:dispatch_to_transport

Conversation

@jcugat

@jcugatjcugat commented May 30, 2020

Copy link
Copy Markdown
Contributor

Since there were still a few uses of dispatch instead of transport in tests, pytest complained about deprecation warnings.

Same thing happened with hard_limit and max_connections from httpx.PoolLimits.

jcugat
jcugat commented May 30, 2020
View reviewed changes
Comment threadhttpx/_models.py
florimondmanca
florimondmanca approved these changes May 30, 2020
View reviewed changes

@florimondmancaflorimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one yup, thanks a lot!

@florimondmancaflorimondmanca added the refactor Issues and PRs related to code refactoring label May 30, 2020
@florimondmanca
florimondmanca merged commit 89a8100 into encode:masterMay 30, 2020
@jcugat
jcugat deleted the dispatch_to_transport branch May 31, 2020 09:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@florimondmancaflorimondmancaflorimondmanca approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactorIssues and PRs related to code refactoring

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcugat@florimondmanca