Uh oh!
There was an error while loading. Please reload this page.
Update contributing docs - #1011
Merged
yeraydiazdiaz merged 4 commits intoJun 2, 2020
Merged
Conversation
jcugat
reviewed
May 31, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jcugat
approved these changes
May 31, 2020
jcugat
left a comment
Contributor
There was a problem hiding this comment.
Not sure if I can approve but LGTM 👍
florimondmanca
commented
May 31, 2020
Contributor
@jcugat Would you be keen to join @encode/maintainers? No expectations, but you'd be able to approve PRs and move them to a mergeable state — extra eyes and reducing the bus factor is always great. :-) What do others think? |
jcugat
commented
May 31, 2020
Contributor
I'm still making my way through all the code, but sure, I'll try to give a hand where I can 🙂 |
florimondmanca
commented
May 31, 2020
Contributor
Hmm, doesn't look like I can add members to the team. @tomchristie Any chance you can help out? |
Co-authored-by: Josep Cugat <jcugat@gmail.com>
Co-authored-by: Josep Cugat <jcugat@gmail.com>
Co-authored-by: Josep Cugat <jcugat@gmail.com>
yeraydiazdiazforce-pushed
the
update-contributing-docs
branch
from
June 2, 2020 09:28
6664a87 to
2c755caCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/encode/httpx/issues/936