Uh oh!
There was an error while loading. Please reload this page.
Increase test coverage - take 2 - #1012
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
yeraydiazdiaz
left a comment
There was a problem hiding this comment.
Hey, thanks for your work on this, nice job 💯
The only other usage is from the api.stream method but that is always called from a sync context, so the aexit will never have close_client=True. Should it be removed?
I would say so, seems like dead code.
Left a few suggestions on your comments but in general LGTM 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lovelydinosaur
commented
Jun 1, 2020
Fantastic work, thanks so much! Going to leave this one with @yeraydiazdiaz since he's got a better handle on it, but tested locally and looking really nice. Will try to help with the follow-up once it's in. |
Uh oh!
There was an error while loading. Please reload this page.
yeraydiazdiaz
left a comment
There was a problem hiding this comment.
This looks great. Thanks @jcugat 🚀
More work towards #316, continuation of #1003
After this is merged, the only remaining untested part will be
URLLib3Transport.Small note about
StreamContextManager. The only line not tested is because the only usage of the context manager in an async environment is from BaseClient.stream where it doesn't use theclose_clientparameter (and by default isfalse). The only other usage is from the api.stream method but that is always called from a sync context, so the__aexit__will never haveclose_client=True. Should it be removed?