Uh oh!
There was an error while loading. Please reload this page.
Refactor ASGITransport.request() - #1021
Merged
Merged
Conversation
florimondmancaforce-pushed
the
refactor-asgi
branch
from
June 13, 2020 13:41
1abaca4 to
048dd83Compare| await self.app(scope, receive, send) | ||
| except Exception: | ||
| if self.raise_app_exceptions or not response_complete: | ||
| if self.raise_app_exceptions or not response_complete.is_set(): |
ContributorAuthor
There was a problem hiding this comment.
I think this was a typo before.
Contributor
There was a problem hiding this comment.
Think that was my mistake. Missed this when changing response_complete from a bool to an event. Also didn't realise the nonlocal could be removed 😬
JayH5
approved these changes
Jun 13, 2020
| await self.app(scope, receive, send) | ||
| except Exception: | ||
| if self.raise_app_exceptions or not response_complete: | ||
| if self.raise_app_exceptions or not response_complete.is_set(): |
Contributor
There was a problem hiding this comment.
Think that was my mistake. Missed this when changing response_complete from a bool to an event. Also didn't realise the nonlocal could be removed 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by #998 (comment), small bit of refactoring for
ASGITransportto help reduce the diff there. I think these are valid readability improvements any case.typingimport style.nonlocal's