Skip to content

Make isort configuration compatible with isort v5 - #1050

Merged
lovelydinosaur merged 2 commits into
encode:masterfrom
hukkin:isort-v5
Jul 4, 2020
Merged

Make isort configuration compatible with isort v5#1050
lovelydinosaur merged 2 commits into
encode:masterfrom
hukkin:isort-v5

Conversation

@hukkin

@hukkinhukkin commented Jul 4, 2020

Copy link
Copy Markdown

See https://timothycrosley.github.io/isort/CHANGELOG/

isort removed the flags --recursive and --apply. They are the default behavior in isort v5.

Comment threadsetup.cfg
check_untyped_defs = True

[tool:isort]
profile = black

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yas!

@lovelydinosaur

Copy link
Copy Markdown
Member

Great stuff!

@lovelydinosaur
lovelydinosaur merged commit 8dea2c2 into encode:masterJul 4, 2020
@florimondmanca

Copy link
Copy Markdown
Contributor

Nice, issued a similar PR for HTTPCore… encode/httpcore#111

@jcugatjcugat mentioned this pull request Jul 5, 2020
@hukkin
hukkin deleted the isort-v5 branch August 6, 2020 20:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hukkin@lovelydinosaur@florimondmanca@hukkinj1