Skip to content

client.netrc should be private#1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 2 commits into from
Jul 23, 2020
Merged

client.netrc should be private #1071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
089a474
client.netrc should be private
lovelydinosaur Jul 20, 2020
9ce8548
Merge branch 'master' into netrc-should-be-private
lovelydinosaur Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions httpx/_client.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,7 +80,7 @@ def __init__(
self.timeout = Timeout(timeout)
self.max_redirects = max_redirects
self.trust_env = trust_env
self.netrc = NetRCInfo()
self._netrc = NetRCInfo()

def _get_proxy_map(
self, proxies: typing.Optional[ProxiesTypes], trust_env: bool,
Expand DownExpand Up@@ -269,7 +269,7 @@ def _build_auth(self, request: Request, auth: AuthTypes = None) -> Auth:
return BasicAuth(username=username, password=password)

if self.trust_env and "Authorization" not in request.headers:
credentials = self.netrc.get_credentials(request.url.authority)
credentials = self._netrc.get_credentials(request.url.authority)
if credentials is not None:
return BasicAuth(username=credentials[0], password=credentials[1])

Expand Down