Skip to content

Consistent multidict methods - #1089

Merged
lovelydinosaur merged 5 commits into
masterfrom
consistent-multidict-methods
Jul 31, 2020
Merged

Consistent multidict methods#1089
lovelydinosaur merged 5 commits into
masterfrom
consistent-multidict-methods

Conversation

@lovelydinosaur

@lovelydinosaurlovelydinosaur commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Nice sensible symmetry and expected behaviours across each of the following...

  • Headers.get
  • Headers.get_list
  • Headers.items
  • Headers.multi_items
  • QueryParams.get
  • QueryParams.get_list
  • QueryParams.items
  • QueryParams.multi_items

The following have been renamed, but the synonyms remain, and are now pending deprecation...

  • Headers.getlist() -> Headers.get_list()
  • QueryParams.getlist() -> QueryParams.get_list()

@lovelydinosaurlovelydinosaur added this to the v0.14 milestone Jul 27, 2020
@lovelydinosaurlovelydinosaur added the user-experience Ensuring that users have a good experience using the library label Jul 27, 2020
florimondmanca
florimondmanca approved these changes Jul 30, 2020
View reviewed changes

@florimondmancaflorimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Comment threadhttpx/_models.py Outdated
Comment threadhttpx/_models.py Outdated
lovelydinosaurand others added 3 commits July 31, 2020 11:28
@lovelydinosaur@florimondmanca
Update httpx/_models.py
57d1e61
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
@lovelydinosaur@florimondmanca
Update httpx/_models.py
0b0adf2
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
@lovelydinosaur
Merge branch 'master' into consistent-multidict-methods
657372c
@lovelydinosaur
lovelydinosaur merged commit 2ba9c1e into masterJul 31, 2020
@lovelydinosaur
lovelydinosaur deleted the consistent-multidict-methods branch July 31, 2020 10:46
@florimondmancaflorimondmanca mentioned this pull request Aug 1, 2020
Merged
@lovelydinosaurlovelydinosaur mentioned this pull request Aug 6, 2020
Merged
@lovelydinosaurlovelydinosaur mentioned this pull request Aug 20, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@florimondmancaflorimondmancaflorimondmanca approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

user-experienceEnsuring that users have a good experience using the library

Milestone

v0.14

Development

Successfully merging this pull request may close these issues.

2 participants

@lovelydinosaur@florimondmanca