Skip to content

Switch to more concise Timeout parameters - #1111

Merged
lovelydinosaur merged 5 commits into
masterfrom
concise-timeout-params
Aug 1, 2020
Merged

Switch to more concise Timeout parameters#1111
lovelydinosaur merged 5 commits into
masterfrom
concise-timeout-params

Conversation

@florimondmanca

@florimondmancaflorimondmanca commented Aug 1, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #1093

httpx.Timeout(read_timeout=1, write_timeout=1, connect_timeout=5, pool_timeout=10)

Becomes:

httpx.Timeout(read=1, write=1, connect=5, pool=10)

@florimondmancaflorimondmanca added the user-experience Ensuring that users have a good experience using the library label Aug 1, 2020
@florimondmanca
florimondmanca requested a review from a teamAugust 1, 2020 09:29
florimondmanca
florimondmanca commented Aug 1, 2020
View reviewed changes
Comment threadhttpx/_config.py Outdated
florimondmanca
florimondmanca commented Aug 1, 2020
View reviewed changes
Comment threaddocs/advanced.md
**read**, **write**, and **pool** timeouts.

* The **connect timeout** specifies the maximum amount of time to wait until
* The **connect** timeout specifies the maximum amount of time to wait until

@florimondmancaflorimondmancaAug 1, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change in emphasis is so that it's clearer now that the usage is connect=.... :-)

@lovelydinosaurlovelydinosaurAug 1, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, yes.

lovelydinosaur
lovelydinosaur approved these changes Aug 1, 2020
View reviewed changes

@lovelydinosaurlovelydinosaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Much neater. 😀

@lovelydinosaur
lovelydinosaur merged commit 26cd4f5 into masterAug 1, 2020
@lovelydinosaur
lovelydinosaur deleted the concise-timeout-params branch August 1, 2020 18:59
@lovelydinosaurlovelydinosaur mentioned this pull request Aug 6, 2020
Merged
@coderabbitaicoderabbitaiBot mentioned this pull request Jun 8, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaurlovelydinosaurlovelydinosaur approved these changes

Assignees

No one assigned

Labels

user-experienceEnsuring that users have a good experience using the library

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

More concise Timeout parameters.

2 participants

@florimondmanca@lovelydinosaur