Uh oh!
There was an error while loading. Please reload this page.
Improve docs on client/request configuration merging - #1116
Improve docs on client/request configuration merging#1116florimondmanca wants to merge 2 commits into
Conversation
lovelydinosaur
commented
Aug 1, 2020
An alternative here would be to do the UNSET dance on each of these parameters, so that they do have the expected behaviour when passing Would that make sense? |
Well, hmm, I don't know. We already provide the "build a request and edit its headers/params/cookies to remove items" solution for these cases. Plus, I don't know if the use case for "send absolutely no headers/params/cookies on this request" is that convincing. On the contrary there might a drawback which is that this change would be breaking to people that do pass On the other hand, the argument for |
lovelydinosaur
commented
Aug 5, 2020
So, I think I'm in favour of #1115 for auth, right? It's come up as an issue for us, and it's come up as an issue for requests, plus I can fairly easily see the use cases for it. But yes, otherwise I guess we can be okay with |
florimondmanca
commented
Aug 5, 2020
Yup, that's my sentiment as well. Will reopen #1115. |
Fixes #1004
Update the Merging configuration docs to resolve these items:
Noneat the request level. Improve example snippet by usingX-Client-HeaderandX-Request-Headerexample headers.auth=Nonedoesn't disable auth, even though request-levelauthis advertised as generally taking precedence over client-levelauth.