Uh oh!
There was an error while loading. Please reload this page.
Use get_list consistently - #1119
Merged
Merged
Conversation
florimondmanca
approved these changes
Aug 2, 2020
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Looks good, a tiny suggestion!
| assert h["a"] == "123, 456" | ||
| assert h.get("a") == "123, 456" | ||
| assert h.get("nope", default=None) is None | ||
| assert h.getlist("a") == ["123", "456"] |
Contributor
There was a problem hiding this comment.
Do we want a with pytest.warns(DeprecatedWarning) here and in test_params(), so that these known warnings don't show up in the pytest output?
MemberAuthor
There was a problem hiding this comment.
💯 - Yes, thanks! Which helped catch that they needed to be DeprecationWarning in line with everything else (not PendingDeprecationWarning).
j178
approved these changes
Aug 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled through from a nice catch in #1118
I'd assumed that we ought to pragma: nocover these cases, rather than test them, but on a second look this does seem to be the pragmatic option, so let's just roll with it.
Thanks to @j178 for this!