Skip to content

Fixed warnings in unit tests suite, caused by #1127 PR - #1137

Merged
lovelydinosaur merged 1 commit into
encode:masterfrom
cdeler:fixed_warnings_in_unit_tests_caused_by_proxies_param_changes
Aug 6, 2020
Merged

Fixed warnings in unit tests suite, caused by #1127 PR#1137
lovelydinosaur merged 1 commit into
encode:masterfrom
cdeler:fixed_warnings_in_unit_tests_caused_by_proxies_param_changes

Conversation

@cdeler

@cdelercdeler commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

@tomchristie

I'm sorry, I've missed that the changes from #1127 caused several warnings during test suite executing. I've fixed that

UPD Probably we can enhance CI adding -W error to the pytest invocation?

@cdeler
cdelerforce-pushed the fixed_warnings_in_unit_tests_caused_by_proxies_param_changes branch from 4206375 to ce08fc6CompareAugust 6, 2020 12:18
@lovelydinosaur
lovelydinosaur merged commit 0a38695 into encode:masterAug 6, 2020
@cdeler
cdeler deleted the fixed_warnings_in_unit_tests_caused_by_proxies_param_changes branch September 9, 2020 14:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cdeler@lovelydinosaur