Uh oh!
There was an error while loading. Please reload this page.
Set __module__ = 'httpx' on everything we expose via the public API. - #1155
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
felix-hilden
commented
Aug 10, 2020
Contributor
Glad to see this was useful! And using locals is a neat way of doing it. Should a similar issue be opened in (Also apologies if I'm intrusive, not really sure what conversation should be on Gitter or here...) |
lovelydinosaur
commented
Aug 10, 2020
ContributorAuthor
Yeah good call re. applying the same to |
felix-hilden
approved these changes
Aug 11, 2020
felix-hilden
left a comment
Contributor
There was a problem hiding this comment.
For what it's worth, it looks good to me! Having it on functions too is certainly good for consistency 👍
florimondmanca
approved these changes
Aug 11, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
__module__ = 'httpx'on all our public API.Primarily useful for classes that haven't declared a
__repr__method, but might also improve the output of other code-introspection tooling?Before:
After: