Skip to content

Map rfc3986 exceptions - #1163

Merged
lovelydinosaur merged 5 commits into
encode:masterfrom
j178:map-rfc3986-exception
Aug 11, 2020
Merged

Map rfc3986 exceptions#1163
lovelydinosaur merged 5 commits into
encode:masterfrom
j178:map-rfc3986-exception

Conversation

@j178

@j178j178 commented Aug 11, 2020

Copy link
Copy Markdown
Contributor

Closes #1158

@j178
j178force-pushed the map-rfc3986-exception branch from 79fe5b9 to 142ca22CompareAugust 11, 2020 04:42

@lovelydinosaurlovelydinosaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastically put together pull request! Yes, thank you.

One tiny amendment suggested, then let's get it in!

Comment threadhttpx/_client.py Outdated

@florimondmancaflorimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one!

@lovelydinosaur
lovelydinosaur merged commit 45de714 into encode:masterAug 11, 2020
@j178
j178 deleted the map-rfc3986-exception branch August 11, 2020 08:49
This was referenced Aug 11, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Map rfc3986.exceptions.InvalidAuthority to httpx.InvalidURL

3 participants

@j178@lovelydinosaur@florimondmanca