Make name in httpx.__init__ private

[j178]

Prompted by encode/httpcore@35ecd22

[jcugat]

Would be worth bringing this test to httpx, since it's the one that surfaced the issue. Also, I'd use private variables _* instead of using del.

[j178]

@jcugat Thanks for reminding me! I added a test and reorder members in __all__.

Also, I'd use private variables _* instead of using del.

I think these are just temporary variables, they will not be used anywhere, I prefer deling them from the namespace.

[lovelydinosaur]

So, really I think the change footprint in the is just too big, and we really don't need to be deling private variables.

Switching name to _name is sensible tho.

I'd prefer not to add the test here either - sometimes testing at this kind of level is just adding extra maintenance work, and bloat, without any real benefit.

[j178]

Updated.

[lovelydinosaur]

👍

[jcugat]

@tomchristie The test was added because one of the imports was not present inside __all__, and it's easy to forget to keep them synced. I don't understand what extra maintenance work that test is adding.

[lovelydinosaur]

You're right sorry. I was taking a brief look on a phone screen, and it seemed a bit superfluous But it's actually reasonable enough.