Skip to content

Enable redirects by default for HEAD requests - #1183

Merged
florimondmanca merged 3 commits into
encode:masterfrom
dongskyler:feature/set-default-allow-redirects-to-true
Aug 16, 2020
Merged

Enable redirects by default for HEAD requests#1183
florimondmanca merged 3 commits into
encode:masterfrom
dongskyler:feature/set-default-allow-redirects-to-true

Conversation

@dongskyler

Copy link
Copy Markdown
Contributor

Fix #1146

This PR sets default allow_redirects to True. It was False before this PR.

This will align our behavior with most other http request libraries, except for Requests.

@florimondmancaflorimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! I'll add a test in a follow-up PR. :-)

@florimondmanca
florimondmanca merged commit a226c60 into encode:masterAug 16, 2020
@florimondmancaflorimondmanca changed the title Fix #1146 Set default allow_redirects to trueEnable redirects by default for HEAD requestsAug 16, 2020
@dongskyler

Copy link
Copy Markdown
ContributorAuthor

Sounds great.

@dongskyler
dongskyler deleted the feature/set-default-allow-redirects-to-true branch August 16, 2020 12:52
j178 added a commit that referenced this pull request Aug 20, 2020
@j178j178 mentioned this pull request Aug 20, 2020
j178 added a commit that referenced this pull request Aug 20, 2020
j178 added a commit that referenced this pull request Aug 20, 2020
j178 added a commit that referenced this pull request Aug 20, 2020
Co-authored-by: Tom Christie <tom@tomchristie.com>
@lovelydinosaurlovelydinosaur mentioned this pull request Aug 21, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

allow_redirects with httpx.head(...)

2 participants

@dongskyler@florimondmanca