Made cookies construct-able from a list of tuples

[cdeler]

I changed CookieTypes, added the test as it's said in https://github.com/encode/httpx/issues/1209

[florimondmanca]

Looks good!

Question: do we allow only lists for other parameters such as headers and data, or do they a more general Sequence of tuples? Just wanted to make sure we're also being consistent there.

[cdeler]

@florimondmanca
As I see, headers (mentioned in the issue) could be a Sequence

httpx/httpx/_types.py

Lines 40 to 46 in 15c1e42

	HeaderTypes=Union[
	"Headers",
	Dict[str, str],
	Dict[bytes, bytes],
	Sequence[Tuple[str, str]],
	Sequence[Tuple[bytes, bytes]],
	]

[florimondmanca]

Yes, but on the other hand query params accept a List, so hmm. Maybe it's a separate discussion we can have. I do remember that we've had issues with mypy flagging some cases as not acceptable, which required using sequence and mapping instead of list and dict, so maybe that's where these differences come from.

Anyway this PR is consistent with itself - only accept a list of tuples. If we find out that we need to expand to a sequence then let's reconsider at that point? (So far the usage of Dict with cookies doesn't seem to have been a problem.)

[cdeler]

Now I see that https://github.com/encode/httpx/issues/1209 is related to Sequence (I'm pretty sure that it was List, but may be I need to take a nap).

I see that you have accepted the ticket, but can I change List to Sequence in the PR?

Update
@florimondmanca

I changed typing from List to Sequence, it's a bit confusing for me that I mis-read the original issue.

If commits-after-approval are not allowed, I can revert it back

[florimondmanca]

@cdeler As discussed on Gitter, could we consider sticking to List instead of Sequence for now?

(We can add Sequence if we need to later, but adding it right now means more API surface that's not necessarily required, which we generally want to keep at the lowest level possible. Makes sense?)

[cdeler]

@cdeler As discussed on Gitter, could we consider sticking to List instead of Sequence for now?

(We can add Sequence if we need to later, but adding it right now means more API surface that's not necessarily required, which we generally want to keep at the lowest level possible. Makes sense?)

Yes, sure, give me a second

[cdeler]

@florimondmanca I've reverted the last commit (so the PR contains List for now)

[florimondmanca]

LGTM! Feel free to merge when you're ready. :)