Uh oh!
There was an error while loading. Please reload this page.
Better test case consistency. Prefer import httpx and httpx.Client. - #1222
Merged
Conversation
import httpx and httpx.Client.lovelydinosaur
marked this pull request as ready for review
August 26, 2020 11:57
florimondmanca
approved these changes
Aug 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import httpxrather than usingfrom httpx import ....httpx.Client()rather thanhttpx.AsyncClientunless there's a reason to be using async.Required footprint for #1219 should be much smaller after this.