Uh oh!
There was an error while loading. Please reload this page.
Type error on invalid url type - #1259
Merged
florimondmanca merged 3 commits intoSep 4, 2020
Merged
Conversation
florimondmanca
approved these changes
Sep 4, 2020
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Neat little contribution — definitely see the point in preventing users from using other types named URL from related libraries.
A nit, but approving in advance…
Uh oh!
There was an error while loading. Please reload this page.
wozniaktyforce-pushed
the
type-error-on-invalid-url-type
branch
from
September 4, 2020 21:07
6c993b4 to
62d08dfComparewozniaktyforce-pushed
the
type-error-on-invalid-url-type
branch
from
September 4, 2020 21:10
62d08df to
eac4390Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1258
Note: first contribution, so let me know if I'm missing anything