Skip to content

Minor decoder refactoring. - #1276

Merged
lovelydinosaur merged 5 commits into
masterfrom
decoder-refactoring
Sep 10, 2020
Merged

Minor decoder refactoring.#1276
lovelydinosaur merged 5 commits into
masterfrom
decoder-refactoring

Conversation

@lovelydinosaur

Copy link
Copy Markdown
Contributor
  • Drop response.decoder property, since we don't actually want to expose the decode API. (Refs #1275)
  • Decoder -> ContentDecoder. (Since it's more obviously distinct from TextDecoder, LineDecoder, rather than looking like a base class for all of them, which it isn't.)

@lovelydinosaurlovelydinosaur added the refactor Issues and PRs related to code refactoring label Sep 10, 2020

@florimondmancaflorimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lovelydinosaur
lovelydinosaur merged commit 6006721 into masterSep 10, 2020
@lovelydinosaur
lovelydinosaur deleted the decoder-refactoring branch September 10, 2020 14:10
@lovelydinosaurlovelydinosaur mentioned this pull request Sep 21, 2020
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactorIssues and PRs related to code refactoring

Development

Successfully merging this pull request may close these issues.

2 participants

@lovelydinosaur@florimondmanca