Uh oh!
There was an error while loading. Please reload this page.
Made Request.prepare private (i.e. renamed it to _prepare) - #1280
Closed
cdeler wants to merge 3 commits into
Closed
Conversation
cdeler
marked this pull request as draft
September 11, 2020 09:18
cdelerforce-pushed
the
tightening-public-API-on-models
branch
from
September 11, 2020 16:04
e254aa3 to
9adc8d9Comparecdeler
marked this pull request as ready for review
September 11, 2020 16:07
StephenBrown2
commented
Sep 11, 2020
Contributor
This has a lot of changes unrelated to the title, can you back those out and submit them as separate PRs? |
ContributorAuthor
Sure, thank you. I'm marking that as a draft I had had a glitch with pipeline, I thought that making this pr "ready" could solve something) |
cdeler
marked this pull request as draft
September 11, 2020 17:44
cdeler
commented
Sep 11, 2020
ContributorAuthor
Closing the PR, it will be split |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a PR regarding to https://github.com/encode/httpx/issues/1275
I renamed
Request.prepareto_preparemaking this method private