Skip to content

Refactor test_auth.py to use MockTransport class. - #1288

Merged
lovelydinosaur merged 2 commits into
masterfrom
refactor-test-auth
Sep 14, 2020
Merged

Refactor test_auth.py to use MockTransport class.#1288
lovelydinosaur merged 2 commits into
masterfrom
refactor-test-auth

Conversation

@lovelydinosaur

@lovelydinosaurlovelydinosaur commented Sep 14, 2020

Copy link
Copy Markdown
Member

Follow up to #1281 - refactors test_auth.py to use the nice MockTransport class.

Possible later follow ups here...

  • We should switch over to a plain import httpx. (test_auth.py uses from httpx import ... for a bunch of stuff, where we're mostly now sticking with a style of import httpx in other test cases.)
  • There's a bunch of test cases that are currently async, but could probably be plain sync cases, which we should prefer where possible.

@lovelydinosaurlovelydinosaur added the refactor Issues and PRs related to code refactoring label Sep 14, 2020
florimondmanca
florimondmanca approved these changes Sep 14, 2020
View reviewed changes

@florimondmancaflorimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@lovelydinosaur
lovelydinosaur merged commit 2d6c30d into masterSep 14, 2020
@lovelydinosaur
lovelydinosaur deleted the refactor-test-auth branch September 14, 2020 16:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@florimondmancaflorimondmancaflorimondmanca approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactorIssues and PRs related to code refactoring

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lovelydinosaur@florimondmanca