Skip to content

Fix response.elapsed#1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 2 commits into from
Sep 23, 2020
Merged

Fix response.elapsed #1313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c789ef5
Fix response.elapsed
lovelydinosaur Sep 23, 2020
48b2859
Merge branch 'master' into fix-elapsed
lovelydinosaur Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions httpx/_client.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -859,7 +859,7 @@ def _send_single_request(self, request: Request, timeout: Timeout) -> Response:
)

def on_close(response: Response) -> None:
response.elapsed = datetime.timedelta(timer.sync_elapsed())
response.elapsed = datetime.timedelta(seconds=timer.sync_elapsed())
if hasattr(stream, "close"):
stream.close()

Expand DownExpand Up@@ -1504,7 +1504,7 @@ async def _send_single_request(
)

async def on_close(response: Response) -> None:
response.elapsed = datetime.timedelta(await timer.async_elapsed())
response.elapsed = datetime.timedelta(seconds=await timer.async_elapsed())
if hasattr(stream, "close"):
await stream.aclose()

Expand Down