Uh oh!
There was an error while loading. Please reload this page.
Handle default ports in WSGITransport - #1469
Merged
Merged
Conversation
https://www.python.org/dev/peps/pep-3333/#environ-variables > SERVER_NAME, SERVER_PORT > When HTTP_HOST is not set, these variables can be combined to determine a default. See the URL Reconstruction section below for more detail. SERVER_NAME and SERVER_PORT are required strings and must never be empty.
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Good catch!
Also, is there a unit test we could add in test_wsgi.py about this?
Uh oh!
There was an error while loading. Please reload this page.
florimondmanca
commented
Feb 16, 2021
Contributor
@abersheeran I went ahead and pushed some commits for the modifications to get this PR in shape, hope you don't mind. |
florimondmanca
approved these changes
Feb 16, 2021
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much for this contribution!
We're not sure yet when 0.17.0 will be released (the team needs to circle back on that), but once merged this would at least be available for git installation.
abersheeran
commented
Feb 16, 2021
ContributorAuthor
Thank you for your quick response~ |
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.python.org/dev/peps/pep-3333/#environ-variables
Fixed #1468