Uh oh!
There was an error while loading. Please reload this page.
Differentiate between 'url.host' and 'url.raw_host' - #1590
Conversation
StephenBrown2
commented
Apr 22, 2021
Wouldn't |
StephenBrown2
left a comment
There was a problem hiding this comment.
Just a couple typos, and the previous question about what raw means.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Raw, as in the "the raw bytes on the wire", or "the raw ingredients that make up the cake". Or, in baking... The raw ingredients: Similar usage of "Raw" in other technical docs. |
lovelydinosaur
commented
Apr 23, 2021
Thanks so much for the review @StephenBrown2. |
StephenBrown2
commented
Apr 23, 2021
I think it was mainly just a copy-paste issue that got propagated, but no more |
Refs #1275
Throughout our URL model we're differentiating neatly between byte-wise cases and str cases.
We're always using bytes when escaping is not applied, and str when escaping is applied.
Eg...
This pull request is a proposal for treating IDNA domain names similarly, so...
For API consistency this also necessarily results in
url.netlocbecoming a byte interface, which actually makes sense for the contexts in which it is used.Finally we also introduce
.raw_schemefor a byte-wise representation of the scheme, for a nice consistency so that: