Skip to content

update requests compatibility docs on query and form params - #2461

Merged
lovelydinosaur merged 1 commit into
encode:masterfrom
falkben:requests_compat_params_form
Nov 25, 2022
Merged

update requests compatibility docs on query and form params#2461
lovelydinosaur merged 1 commit into
encode:masterfrom
falkben:requests_compat_params_form

Conversation

@falkben

Copy link
Copy Markdown
Contributor

Following up on #2330 (reply in thread) I added a note about requests compatibility with form data and query params -- namely that httpx only supports dictionaries whereas requests also supports lists of tuples.

As suggested, I added this note after the Query Parameters section, however, it might also bear mentioning in the Request Content section?

@lovelydinosaurlovelydinosaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, yup.

@lovelydinosaur
lovelydinosaur merged commit 8e5e3b8 into encode:masterNov 25, 2022
@lovelydinosaur

Copy link
Copy Markdown
Contributor

however, it might also bear mentioning in the Request Content section?

Not sure. We could leave it as-is and await further feedback perhaps?

@falkben

Copy link
Copy Markdown
ContributorAuthor

however, it might also bear mentioning in the Request Content section?

Not sure. We could leave it as-is and await further feedback perhaps?

Sounds good!

@falkben
falkben deleted the requests_compat_params_form branch November 25, 2022 14:27
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@falkben@lovelydinosaur