Skip to content

Change the type of Extensions from Mapping to MutableMapping.#2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karpetrosyan merged 9 commits into from
Sep 11, 2023
+5 −3
Merged

Change the type of Extensions from Mapping to MutableMapping. #2803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
23fc2cf
Change extensions type
karpetrosyan Aug 1, 2023
26ac893
Update changelog
karpetrosyan Aug 1, 2023
1813c6a
install httpcore from the git
karpetrosyan Aug 1, 2023
f608018
Revert "install httpcore from the git"
karpetrosyan Aug 1, 2023
136a702
Merge branch 'master' into change-response-extensions-type
karpetrosyan Aug 7, 2023
1c3ec75
Merge branch 'master' into change-response-extensions-type
lovelydinosaur Aug 28, 2023
27aa3ed
bump httpcore version
karpetrosyan Sep 8, 2023
73e7674
fix requirements
karpetrosyan Sep 8, 2023
ad334c4
Merge branch 'master' into change-response-extensions-type
karpetrosyan Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Added

* Change the type of `Extensions` from `Mapping[Str, Any]` to `MutableMapping[Str, Any]`. (#2803)
* Add `socket_options` argument to `httpx.HTTPTransport` and `httpx.AsyncHTTPTransport` classes. (#2716)
* The `Response.raise_for_status()` method now returns the response instance. For example: `data = httpx.get('...').raise_for_status().json()`. (#2776)

Expand Down
5 changes: 3 additions & 2 deletions httpx/_types.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@
Iterator,
List,
Mapping,
MutableMapping,
NamedTuple,
Optional,
Sequence,
Expand DownExpand Up@@ -87,7 +88,7 @@

RequestContent = Union[str, bytes, Iterable[bytes], AsyncIterable[bytes]]
ResponseContent = Union[str, bytes, Iterable[bytes], AsyncIterable[bytes]]
ResponseExtensions = Mapping[str, Any]
ResponseExtensions = MutableMapping[str, Any]

RequestData = Mapping[str, Any]

Expand All@@ -104,7 +105,7 @@
]
RequestFiles = Union[Mapping[str, FileTypes], Sequence[Tuple[str, FileTypes]]]

RequestExtensions = Mapping[str, Any]
RequestExtensions = MutableMapping[str, Any]


class SyncByteStream:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ classifiers = [
]
dependencies = [
"certifi",
"httpcore>=0.17.2,<0.18.0",
Comment thread
karpetrosyan marked this conversation as resolved.
"httpcore>=0.18.0,<0.19.0",
"idna",
"sniffio",
]
Expand Down