Uh oh!
There was an error while loading. Please reload this page.
Version 0.25.2 - #2957
Conversation
lovelydinosaur
commented
Nov 23, 2023
Great. We could also mention that we're enforcing Happy to help get this released if needed. |
karpetrosyan
commented
Nov 23, 2023
We can also consider adding #2879 to this release if you wish. I think it would be better to start migration to the new proxy API as soon as possible. |
lovelydinosaur
commented
Nov 23, 2023
I'd also appreciate get that in soon, tho it's an API change and needs to be part of a major release. |
karpetrosyan
commented
Nov 23, 2023
Do we really need a major release to add a new public API? (when we do support the previous one) SEMVER says
I thought we would release a major version if the previous API was deleted. |
karpetrosyan
commented
Nov 23, 2023
Also this: https://semver.org/#spec-item-7
and this https://semver.org/#spec-item-7
|
lovelydinosaur
commented
Nov 23, 2023
It's an (somewhat) incompatible API change, since it introduces a deprecation warning with the current usage. |
karpetrosyan
commented
Nov 23, 2023
Deprecation cases are mentioned here, or am I missing something? Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backward compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented. |
lovelydinosaur
commented
Nov 23, 2023
We've got a few type annotations and we're updating our dependancies. Let's roll a minor release for that. #2879 introduces an API change and shouldn't be included. The rest is just noise. |
karpetrosyan
commented
Nov 23, 2023
Should I draft a new release? Or you want to do it yourself. |
lovelydinosaur
commented
Nov 23, 2023
I don't mind. Do team members have the correct permissions for the "draft a new release" control on this page? |
karpetrosyan
commented
Nov 23, 2023
Yes, it seems I have enough permissions to do that. I have set the release date to tomorrow. |
Uh oh!
There was an error while loading. Please reload this page.
karpetrosyan
commented
Nov 24, 2023
Are you fine with releasing this @tomchristie? It seems I can't run the workflow for release. |
lovelydinosaur
commented
Nov 24, 2023
Our process (for visibility)...
|
karpetrosyan
commented
Nov 24, 2023
Here is the 0.25.2 release: https://github.com/encode/httpx/releases/tag/0.25.2 Now it's time for @encode/operations to double-check and run the workflow. |
lovelydinosaur
commented
Nov 24, 2023
* Version 0.25.2 * Update CHANGELOG.md
Changelog
0.25.2
Added
__init__()methods. (add missing type hints to __init__(...) #2938)