Uh oh!
There was an error while loading. Please reload this page.
Fixed iter_text adding an empty string - #2998
Conversation
jamesbraza
commented
Dec 11, 2023
Looks like |
jamesbraza
commented
Dec 11, 2023
@tomchristie so since |
Uh oh!
There was an error while loading. Please reload this page.
lovelydinosaur
commented
Dec 11, 2023
I think it's better to add a |
This reverts commit e19a418.
jamesbraza
commented
Dec 11, 2023
Alright, done! Ready for review again @tomchristie and @zanieb 👌 |
lovelydinosaur
commented
Dec 11, 2023
Looks great. Nice tidy lil PR, this. One query on the usage of chain, could probs approve either ways tho. |
Thanks! Yeah, I added the Alternately, |
lovelydinosaur
commented
Dec 11, 2023
Not sure. Perhaps we could consider |
jamesbraza
commented
Dec 11, 2023
I think I was changing the internals of To merge this PR, would you like me to switch to a |
@jamesbraza I think the suggestion is use a no cover pragma then follow with a separate pull request that explores using I'm okay with keeping this as is or that 🤷♀️ |
jamesbraza
commented
Dec 11, 2023
Sounds good, agree two PRs is better. Switched to |
lovelydinosaur
commented
Dec 11, 2023
Wonderful, thanks. (Note to self: CHANGELOG.md updates as part of the PR before ya merge in the future, doofus.) |
jamesbraza
commented
Dec 11, 2023
I will get around to |
Summary
Fixes
TextChunker().decode("")not handling empty string, as exposed in #2995Checklist