Uh oh!
There was an error while loading. Please reload this page.
Add httpx.SSLContext configuration. - #3022
Conversation
897a5de to
88f2ab7Compare
This comment was marked as resolved.
This comment was marked as resolved.
karpetrosyan
commented
Dec 26, 2023
Yes, I agree that removing them completely is not what the user expects. Or should we deprecate them anyway? Not obvious to me. |
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lovelydinosaur
commented
Dec 28, 2023
Looking good.
I'd suggest you don't spin time on that until we've had a clear discussion around the "API finessing" and "Documentation refresh" areas mentioned in https://github.com/encode/httpx/issues/947#issuecomment-1727389402. I like this change, but we'll want to make it as part of a coherent & consistent 1.0 refresh. |
Uh oh!
There was an error while loading. Please reload this page.
httpx.SSLContext configuration.lovelydinosaur
commented
Jan 15, 2024
Okay, shall we take the docs from this comment... #3007 (comment) and include them in the PR? |
karpetrosyan
commented
Jan 15, 2024
I like it |
karpetrosyan
commented
Jan 16, 2024
Have we decided to remove or deprecate the old arguments? |
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: T-256 <132141463+T-256@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Dropping `trust_env` from `httpx.SSLContext()` API.
Uh oh!
There was an error while loading. Please reload this page.
Thanks so much @karpetrosyan - going to merge this into "version-1.0" now, and then apply remaining changes incrementally. Fantastic work!! 😎 |
Sorry, I couldn't find time to finish all the tidy-ups. |
lovelydinosaur
commented
Oct 10, 2024
Thank you so much for your time & dedication @karpetrosyan. 🙌 |
Discussed in #3007
TODO:
Migration examples
Enabling and disabling verification
Use a different set of certificates
Client side certificates
Using alternate SSL contexts