Deprecate `app=...` in favor of explicit `WSGITransport`/`ASGITransport`. by lovelydinosaur · Pull Request #3050 · encode/httpx

lovelydinosaur · 2024-01-11T12:57:52Z

Deprecate the httpx.Client(app=...) and httpx.AsyncClient(app=...) shortcuts.

Instead of...

client=httpx.Client(app=app)

Use this...

transport=httpx.WSGITransport(app=app)
client=httpx.Client(transport=transport)

Instead of...

client=httpx.AsyncClient(app=app)

Use this...

transport=httpx.ASGITransport(app=app)
client=httpx.AsyncClient(transport=transport)

The rationale for this is described in https://github.com/encode/httpx/issues/947#issuecomment-1727389402.

TODO:

Docs.
CHANGELOG.md.
~~Ensure we have a clear section where we outline 1.0 version changes in one place.~~ See Draft 1.0 release notes #3069

Kludex · 2024-01-25T17:38:22Z

This is not deprecation of app=..., it's a removal directly. Is it ok? We usually raise warnings when deprecating paramters, don't we?

T-256 · 2024-01-25T18:58:49Z


+### Removed
+
+* The `app=...` shortcut has been removed. Use the explicit style of `transport=httpx.WSGITransport()` or `transport=httpx.ASGITransport()` instead.


Since this PR is version 1.0 proposal, why don't you track its changelog in #3069 ?

https://github.com/encode/httpx/pull/3069/files#diff-75bb3ae57865eb28e99c3e4fff3efc72a5d49e3f14ac324195b405058cb9731aR13

Then do we need to re-mention it in this PR?
All other open PRs with 1.0 proposal tag don't include changelog independently.

They should do before approval.
(We should include CHANGELOG entries with the PRs as usual.)

lovelydinosaur · 2024-01-26T09:57:06Z

We usually raise warnings when deprecating paramters, don't we?

Yep, so... #3069

There's a proposal for several related changes, that end up with a stricter simpler more consistent API.
We can land these in a 1.0, and need to take a call on what we think is best wrt. hard-change vs. soft deprecation path.

lovelydinosaur · 2024-02-02T10:34:15Z

This is not deprecation of app=..., it's a removal directly. Is it ok? We usually raise warnings when deprecating parameters, don't we?

Thanks @Kludex, based on this I've updated the PR to be just a deprecation at this point.

Once this is merged I'll look at rolling a 0.27 version with the updated docs.

…rt`. (encode#3050) * Deprecate app=... in favour of explicit WSGITransport/ASGITransport * Linting * Linting * Update WSGITransport and ASGITransport docs * Deprecate app * Drop deprecation tests * Add CHANGELOG * Deprecate 'app=...' shortcut, rather than removing it. * Update CHANGELOG * Fix test_asgi.test_deprecated_shortcut

ofer-pd · 2024-09-29T18:58:24Z

There's one more section of docs that needs to be updated - the API reference for Client and AsyncClient don't yet mention that the app param is deprecated.

* Use real task status * Fix pytest of async client encode/httpx#3050

…rt`. (encode#3050) * Deprecate app=... in favour of explicit WSGITransport/ASGITransport * Linting * Linting * Update WSGITransport and ASGITransport docs * Deprecate app * Drop deprecation tests * Add CHANGELOG * Deprecate 'app=...' shortcut, rather than removing it. * Update CHANGELOG * Fix test_asgi.test_deprecated_shortcut

Tom Christie added 3 commits January 11, 2024 12:49

Deprecate app=... in favour of explicit WSGITransport/ASGITransport
80fbfce

Linting
63143fb

Linting
647b250

lovelydinosaur added the 1.0 proposal Pull requests proposing 1.0 API changes label Jan 11, 2024

T-256 reviewed Jan 14, 2024
View reviewed changes

Comment threadhttpx/_client.py Outdated

lovelydinosaur added 3 commits January 15, 2024 10:36

Merge branch 'master' into deprecate-app
7e14912

Update WSGITransport and ASGITransport docs
9f786f2

Merge branch 'master' into deprecate-app
041470b

lovelydinosaur mentioned this pull request Jan 22, 2024
Draft 1.0 release notes #3069
Closed

Tom Christieand others added 5 commits January 25, 2024 12:25

Merge master
943ab73

Merge branch 'master' into deprecate-app
aab0b00

Deprecate app
fb2e30e

Drop deprecation tests
34ff320

Add CHANGELOG
7e34a37

lovelydinosaur requested a review from a teamJanuary 25, 2024 15:58

T-256 reviewed Jan 25, 2024
View reviewed changes

lovelydinosaur added 5 commits January 30, 2024 13:54

Merge branch 'master' into deprecate-app
21b36a5

Deprecate 'app=...' shortcut, rather than removing it.
4ab79fb

Update CHANGELOG
468bdfc

Fix test_asgi.test_deprecated_shortcut
abf9dee

Merge branch 'master' into deprecate-app
ab27c99

lovelydinosaur merged commit cabd1c0 into masterFeb 2, 2024

lovelydinosaur deleted the deprecate-app branch February 2, 2024 13:29

dispensable added a commit to dispensable/helpdesk that referenced this pull request Apr 3, 2025
Fix pytest of async clientencode/httpx#3050
62ca1eb

dispensable added a commit to douban/helpdesk that referenced this pull request Apr 3, 2025
Use real task status (#176)
debb6a1
* Use real task status * Fix pytest of async client encode/httpx#3050

coderabbitaiBot mentioned this pull request Mar 18, 2026
🎨 Palette: Enhanced SSP Report Visuals AGI-Corporation/CMMC#45
Open

This was referenced Apr 12, 2026
001 gurujee foundation staimoorulhassan/GURUJEE#2
Merged
Refactor logging configuration to use log level parameter Mdwiki-TD/svg_translate_web#222
Merged

coderabbitaiBot mentioned this pull request Jun 2, 2026
fix: StreamingResponse event-loop wedge on non-excluded paths (DEV-1150) farsight-ai/auditry#10
Merged
4 tasks

coderabbitaiBot mentioned this pull request Jul 5, 2026
fix(backend): ensure endpoints and logic gates match strict models DashFin-FarDb/financial-asset-relationship-db#1362
Merged
15 tasks

coderabbitaiBot mentioned this pull request Jul 21, 2026
Readiness (Batch 1–3): AI cost-control fix, test isolation, env validation, observability, invite concurrency, recovery, evidence + CI gates TheEyeBeta/AI-Financial-Advisor#258
Merged
4 tasks

Navigation Menu

Uh oh!

Uh oh!

Deprecate `app=...` in favor of explicit `WSGITransport`/`ASGITransport`. - #3050

Deprecate `app=...` in favor of explicit `WSGITransport`/`ASGITransport`.#3050
lovelydinosaur merged 16 commits into
masterfrom
deprecate-app

lovelydinosaur commented Jan 11, 2024•
edited
Loading

Uh oh!

Uh oh!

Kludex commented Jan 25, 2024

Uh oh!

T-256Jan 25, 2024

Uh oh!

lovelydinosaurJan 26, 2024

Uh oh!

T-256Jan 26, 2024•
edited
Loading

Uh oh!

lovelydinosaurJan 26, 2024•
edited
Loading

Uh oh!

lovelydinosaur commented Jan 26, 2024

Uh oh!

lovelydinosaur commented Feb 2, 2024•
edited
Loading

Uh oh!

ofer-pd commented Sep 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants


		### Removed

		* The `app=...` shortcut has been removed. Use the explicit style of `transport=httpx.WSGITransport()` or `transport=httpx.ASGITransport()` instead.

Uh oh!

Uh oh!

Conversation

lovelydinosaur commented Jan 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Kludex commented Jan 25, 2024

Uh oh!

T-256Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

lovelydinosaurJan 26, 2024

Choose a reason for hiding this comment

Uh oh!

T-256Jan 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lovelydinosaurJan 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lovelydinosaur commented Jan 26, 2024

Uh oh!

lovelydinosaur commented Feb 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ofer-pd commented Sep 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

lovelydinosaur commented Jan 11, 2024•
edited
Loading

T-256Jan 26, 2024•
edited
Loading

lovelydinosaurJan 26, 2024•
edited
Loading

lovelydinosaur commented Feb 2, 2024•
edited
Loading