Uh oh!
There was an error while loading. Please reload this page.
Cleanup response.elapsed implementation. - #3345
Merged
Merged
Conversation
T-256
approved these changes
Oct 14, 2024
T-256
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
(Also, IMO we can merge it to master branch already.)
T-256
commented
Oct 14, 2024
Contributor
How can check for elapsed time for unclosed stream? withhttpx.Client() asclient:
withclient.stream("GET", server.url) asresponse:
elapsed= ??? # `response.started_time` could help? |
lovelydinosaur
commented
Oct 17, 2024
ContributorAuthor
@T-256 That's a valid question, tho let's keep this particular PR focused on this particular piece of internal refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More internal refactorings, keeping that codebase clean & sharp.