Uh oh!
There was an error while loading. Please reload this page.
Rename Stream to TCPStream - #339
Merged
Merged
Conversation
sethmlarson
approved these changes
Sep 15, 2019
sethmlarson
left a comment
Contributor
There was a problem hiding this comment.
One comment then merge away 👍
Uh oh!
There was an error while loading. Please reload this page.
florimondmanca
commented
Sep 15, 2019
ContributorAuthor
Thanks! Looks like this could have used a rebase — the master build is broken. 😕 I’ll send a fix tomorrow morning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by https://github.com/encode/httpx/issues/275#issuecomment-531349234, this is a probably valuable refactoring anyway and a good first step towards UDP support.