Uh oh!
There was an error while loading. Please reload this page.
fix: merge existing params in url, close #3433 - #3438
Closed
GreyElaina wants to merge 4 commits into
Closed
Conversation
GreyElaina
marked this pull request as ready for review
December 2, 2024 18:03
1umine
approved these changes
Dec 3, 2024
Kludex
previously approved these changes
Dec 3, 2024
Kludex
commented
Dec 3, 2024
Contributor
Can we add a test here, so we are sure this doesn't break again in the future? |
Kludex
self-requested a review
December 3, 2024 07:33
GreyElaina
commented
Dec 3, 2024
ContributorAuthor
no problem, will present later. |
GreyElaina
commented
Dec 3, 2024
ContributorAuthor
@Kludex tests are ready. |
Kludex
reviewed
Dec 3, 2024
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Thanks, tho see https://github.com/encode/httpx/issues/3433#issuecomment-2514327255. My suggestion would be...
|
GreyElaina
commented
Dec 3, 2024
ContributorAuthor
fine, see you another pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert #3364
Checklist
Edit by @Kludex :