Skip to content

Add test for request params behavior changes (#3364) - #3440

Merged
lovelydinosaur merged 4 commits into
encode:masterfrom
GreyElaina:add-test-request-params
Dec 3, 2024
Merged

Add test for request params behavior changes (#3364)#3440
lovelydinosaur merged 4 commits into
encode:masterfrom
GreyElaina:add-test-request-params

Conversation

@GreyElaina

@GreyElainaGreyElaina commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

Summary

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@GreyElaina

GreyElaina commented Dec 3, 2024

Copy link
Copy Markdown
ContributorAuthor

cc @tomchristie

lovelydinosaur
lovelydinosaur reviewed Dec 3, 2024
View reviewed changes
Comment threadCHANGELOG.md Outdated
GreyElainaand others added 2 commits December 3, 2024 20:35
@lovelydinosaur
lovelydinosaur merged commit 8ecb86f into encode:masterDec 3, 2024
@lovelydinosaur

lovelydinosaur commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

Thanks @GreyElaina@zanieb.

@daniel-kdaniel-k mentioned this pull request Jan 16, 2025
Merged
daniel-k added a commit to enlyze/enlyze-python that referenced this pull request Jan 16, 2025
@daniel-k
Fix incompatibility withhttpx>=0.28(#52)
b188f07
In `httpx==0.28.0`, the handling of GET query parameters has changed in
a backwards-incompatible way. The new behaviour is to replace query
parameters in the URL when parameters are passed via the `params` kwarg.
Our pagination code expects that parameters in the URL get merged with
the additional parameters of the `params` kwarg. This PR explicitly
implements the old behaviour of merging params to fix compatibility with
recent releases of `httpx`.
refs: - encode/httpx#3364
- encode/httpx#3440
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
@GreyElaina@lovelydinosaur@samclearman
Add test for request params behavior changes (encode#3364) (encode#3440)
ee0582a
Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaurlovelydinosaurlovelydinosaur left review comments
@zaniebzaniebzanieb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GreyElaina@lovelydinosaur@zanieb