Skip to content

TimeoutConfig -> Timeout - #591

Merged
lovelydinosaur merged 1 commit into
masterfrom
timeout-cleanup
Dec 4, 2019
Merged

TimeoutConfig -> Timeout#591
lovelydinosaur merged 1 commit into
masterfrom
timeout-cleanup

Conversation

@lovelydinosaur

Copy link
Copy Markdown
Contributor

Starting some timeout cleanup, which will eventually relate to #433, #463, #578, and #435.

First pass here is that we'd really like timeout=httpx.Timeout(read_timeout=5) rather than timeout=httpx.TimeoutConfig(read_timeout=5), so...

  • Renamed TimeoutConfig to Timeout.
  • Included TimeoutConfig synonm.
  • Tweaked exception naming. I'd like TimeoutError here really, but that happens to be a Python built-in. I've gone with RequestTimeout as the base at the moment. (?)

@lovelydinosaur
lovelydinosaur merged commit c033ed1 into masterDec 4, 2019
@lovelydinosaur
lovelydinosaur deleted the timeout-cleanup branch December 4, 2019 11:39
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
Bumps [mkdocs](https://github.com/mkdocs/mkdocs) from 1.3.1 to 1.4.0.
- [Release notes](https://github.com/mkdocs/mkdocs/releases)
- [Commits](mkdocs/mkdocs@1.3.1...1.4.0)
---
updated-dependencies:
- dependency-name: mkdocs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@lovelydinosaur