Uh oh!
There was an error while loading. Please reload this page.
Make 'request' non-optional on responses - #666
Merged
Merged
Conversation
lovelydinosaur
approved these changes
Dec 21, 2019
lovelydinosaur
left a comment
Contributor
There was a problem hiding this comment.
Probably not a bad idea, yup!
Merged
Merged
Kludex referenced
this pull request
in pydantic/httpx2
May 11, 2026
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 8.5.7 to 9.1.5. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Upgrade guide](https://github.com/squidfunk/mkdocs-material/blob/master/docs/upgrade.md) - [Commits](squidfunk/mkdocs-material@8.5.7...9.1.5) --- updated-dependencies: - dependency-name: mkdocs-material dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by https://github.com/encode/httpx/pull/665/files#r360601429:
response.requestis only everNonein our tests, so let's make it non-optional to provide better type-checking UX on the user side.