Uh oh!
There was an error while loading. Please reload this page.
Rename 'next' to 'anext' on Response - #676
Merged
Merged
Conversation
Comment on lines
+479
to
+484
| # NOTE: not using 'self.send_handling_redirects' here, because | ||
| # 'call_next' must reference a function (instead | ||
| # of a method). This ensures that 'inspect.iscoroutinefunction()' | ||
| # checks behave properly. | ||
| Client.send_handling_redirects, | ||
| self, |
ContributorAuthor
There was a problem hiding this comment.
Yes, that's surprising, and possibly related to python/cpython#16600 — details below…
Details (click to expand)
Essentially boils down to…importinspectclassFoo:
asyncdefbar(self):
passfoo=Foo()
bar=functools.partial(foo.bar)
print(inspect.iscoroutinefunction(bar)) # FalseStrangely though, the non-partial'd method behaves just fine…
print(inspect.iscoroutinefunction(foo.bar)) # Truefunctools.partial is definitely doing something weird here, because…
print(functools._unwrap_partial(bar) isfoo.bar) # FalseEven though the unwrapping returns the same underlying function for "non-method" functions…
asyncdeffuncbar():
passpfuncbar=functools.partial(funcbar)
print(functools._unwrap_partial(pfuncbar) isfuncbar) # TrueBut then I realized this is a property of bound methods themselves…
print(foo.barisfoo.bar) # FalseWtf, Python? 🤷♂🤷♂🤷♂🤷♂🤷♂
ContributorAuthor
There was a problem hiding this comment.
Strangely, this workaround doesn't work on 3.6 and 3.7 — CI is failing for those versions. 😕
lovelydinosaur
requested changes
Dec 21, 2019
Uh oh!
There was an error while loading. Please reload this page.
florimondmancaforce-pushed
the
response-anext
branch
from
December 21, 2019 17:59
04b035f to
ae310e3Comparelovelydinosaur
approved these changes
Dec 23, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #667